[PATCH] D153989: [compiler-rt] Move crt into builtins

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Sorry, it's been a week :D I assume that crt doesn't need the builtins to be available for its configure (the way the rest of compiler-rt does)? If so, this LGTM.



================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:57
 
-if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+if(${OS_NAME} MATCHES "AIX")
   include(CompilerRTAIXUtils)
----------------
While you're changing all these (is that important here or just a drive-by fix, btw?), could you either quote them or drop the `${}` to prevent weird things from happening if we have have e.g. an `AIX` variable defined? (https://cmake.org/cmake/help/latest/command/if.html#variable-expansion for context for anyone not familiar with the issue here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153989/new/

https://reviews.llvm.org/D153989