[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

[Jennifer Yu via Phabricator via cfe-commits]

jyu2 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11401-11402
   llvm::Value *Args[] = {
-      emitUpdateLocation(CGF, C->getBeginLoc()),
-      getThreadID(CGF, C->getBeginLoc()),
+      RT.emitUpdateLocation(CGF, C->getBeginLoc()),
+      RT.getThreadID(CGF, C->getBeginLoc()),
       CGF.Builder.CreateConstArrayGEP(CntAddr, 0).getPointer()};
----------------
ABataev wrote:
> RT is needed only for loc and tid, you can preemit them in the member functions and pass here instead of emitting them here and expose private interfaces.
Yes,  Thanks.  Changed.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11422-11428
+                                          const OMPDependClause *CL) {
+  return EmitDoacrossOrdered<OMPDependClause>(*this, CGF, CGM, CL);
+}
+
+void CGOpenMPRuntime::emitDoacrossOrdered(CodeGenFunction &CGF,
+                                          const OMPDoacrossClause *CL) {
+  return EmitDoacrossOrdered<OMPDoacrossClause>(*this, CGF, CGM, CL);
----------------
ABataev wrote:
> Use Cl or just C instead of CL.
Sorry.  Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154180/new/

https://reviews.llvm.org/D154180