[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 30 14:13:53 PDT 2023
arsenm added a comment.
lgtm except for dropping test coverage
================
Comment at: clang/test/Driver/hip-macros.hip:20
// RUN: -mwavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s
-// WAVE64-DAG: #define __AMDGCN_WAVEFRONT_SIZE 64
-// WAVE32-DAG: #define __AMDGCN_WAVEFRONT_SIZE 32
----------------
This shouldn't drop the check for the old one
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154207/new/
https://reviews.llvm.org/D154207
More information about the cfe-commits
mailing list