[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

[Jacob Lambert via Phabricator via cfe-commits]

lamb-j added inline comments.


================
Comment at: clang/docs/AMDGPUSupport.rst:20
+
+Clang supports OpenCL, HIP and OpenMP on amdgpu target.
+
----------------
arsenm wrote:
> "on amdgpu target" doesn't sound grammatical
"for the //amdgpu// target"? or
"on AMD GPU targets?"



================
Comment at: clang/docs/AMDGPUSupport.rst:49
+   * - ``__AMDGCN_CUMODE__``
+     - Defines as 1 if the CU mode is enabled and 0 if the WGP mode is enabled.
+   * - ``__AMDGCN_UNSAFE_FP_ATOMICS__``
----------------
Defined?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154133/new/

https://reviews.llvm.org/D154133