[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

LGTM, thank you for doing this!



================
Comment at: clang/lib/Sema/SemaExpr.cpp:18201
+    // Hence, in correct code any cleanup objects created inside current
+    // evaluation context must be outside the immediate invocation.
+    E = ExprWithCleanups::Create(getASTContext(), E.get(),
----------------
This argument makes sense to me, thanks for documenting why this is correct!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153962/new/

https://reviews.llvm.org/D153962