[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 10:56:07 PDT 2023


dblaikie added a comment.

In D152017#4462263 <https://reviews.llvm.org/D152017#4462263>, @probinson wrote:

>> we might emit member function declarations for call sites in DWARF, for instance
>
> So are you now leaning more toward wanting to emit the "used" declarations as well? I'm sure you don't want to implement it the way we did...

There's already infrastructure to do this for non-member functions, and if we do it the way we do for things like member function template instantiations (they don't go in the "members" list, they just list the type as their "scope"/parent) - it should be relatively easy/the same as for non-member functions, I think.

> I *think* the template parameter thing has more to do with not supporting expressions in all their glory, although I'm fuzzy on that--last time I looked at that stuff was a number of years ago.

Yeah, there are some cases that are really hairy with whole expression mangling, which is unfortunate and I'm not sure what we could do there short of embed a string with the expression in it... :/ but there are some more cases we could do better at with more semantic information than that, such as the case I mentioned like a non-type template parameter of pointer type pointing to a member function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152017/new/

https://reviews.llvm.org/D152017



More information about the cfe-commits mailing list