[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 10:09:45 PDT 2023


sammccall added a comment.

In D153805#4464487 <https://reviews.llvm.org/D153805#4464487>, @bazuzi wrote:

> It looks like D153485 <https://reviews.llvm.org/D153485> changes the context for the last few comments significantly. What's the appetite for adding yet another child commit to the chain D153485 <https://reviews.llvm.org/D153485> is in that exposes the solver directly? Instead of committing this and having D153485 <https://reviews.llvm.org/D153485> make a breaking change to expose the solver directly if that's better in the new context.

Yeah, that's fewer steps but more stuff stacked on top.
I don't feel strongly - happy to make that change later if you'd like to have this available now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153805/new/

https://reviews.llvm.org/D153805



More information about the cfe-commits mailing list