[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

Fri Jun 30 08:44:01 PDT 2023

donat.nagy requested changes to this revision.
donat.nagy added a comment.
This revision now requires changes to proceed.

Thanks for attaching the test results! Unfortunately it seems that it was important to look at them, because I noticed that in the posgresql codebase there are many bug reports on calls like `func1(func2(...), ...)` where the checker does not print the expected "Assuming that 'func2' fails" note: fdopen/dup <https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_stdclf_notetag_interesting_test_2&is-unique=on&report-hash=89e002d193df688460a98fa16ddbc728&report-filepath=%2apg_backup_archiver.c&report-id=1935212>, fstat/fileno <https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_stdclf_notetag_interesting_test_2&is-unique=on&report-hash=72bd6af194eff49937b105496a28a321&report-filepath=%2acopy.c&report-id=1935085>, isatty/fileno <https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_stdclf_notetag_interesting_test_2&is-unique=on&report-hash=9e87a4b3d807ad96b80d9114682659da&report-filepath=%2aprint.c&report-id=1935403>, another isatty/fileno <https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_stdclf_notetag_interesting_test_2&is-unique=on&report-hash=aaa6f8dd1968571fcbe6707cf085e9f1&report-filepath=%2apg_checksums.c&report-id=1935346>, a third isatty/fileno <https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_stdclf_notetag_interesting_test_2&is-unique=on&report-hash=d048a98fd83fea6a58e657dc4357b59f&report-filepath=%2aprint.c&report-id=1935402>, a second dup/fileno <https://codechecker-demo.eastus.cloudapp.azure.com/Default/report-detail?run=postgres_REL_13_0_stdclf_notetag_interesting_test_2&is-unique=on&report-hash=1bae4681b4981e3dbc05d1f3d5e77622&report-filepath=%2apg_backup_tar.c&report-id=1935073> (this is not an exhaustive list, but I think I listed the majority of them).

Please investigate these before merging your commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153776/new/

https://reviews.llvm.org/D153776