[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:318
 
+  Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize));
+  // ToDo: deprecate this macro for naming consistency.
----------------
arsenm wrote:
> If you're renaming it anyway, might as well go for __AMDGPU?
but this will cause inconsistency with `__AMDGCN_CUMODE__` and `__AMDGCN_UNSAFE_FP_ATOMICS__`, and all the other `__amdgcn_*` macros.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154207/new/

https://reviews.llvm.org/D154207