[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

Unrelated but can we get this to start reporting xnack and ecc?



================
Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHIP.cpp:80
+    if (err != hipSuccess) {
+      llvm::errs() << "Failed to get device id for ordinal " << i << "\n";
+      return 1;
----------------
single quotes around '\n'


================
Comment at: clang/tools/amdgpu-arch/AMDGPUArchByHSA.cpp:114
+  for (const auto &GPU : GPUs)
+    printf("%s\n", GPU.c_str());
+
----------------
llvm::outs()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153725/new/

https://reviews.llvm.org/D153725