[PATCH] D154181: [x86] Add missing FeatureCMOV in frontend targets.

Thu Jun 29 21:41:06 PDT 2023

craig.topper added inline comments.

================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:325
+  { {"pentiumpro"}, CK_PentiumPro, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B },
+  { {"i686"}, CK_i686, ~0U, FeatureCMOV | FeatureX87 | FeatureCMPXCHG8B },
   { {"pentium2"}, CK_Pentium2, ~0U, FeaturesPentium2 },
----------------
craig.topper wrote:
> I don't think i686 is supposed to have CMOV. There are some "6th generation" CPUs from Via maybe that don't have cmov.
Nevermind. I guess we have it enabled for i686. So if I am remembering the Via CPUs correctly, the damage is already done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154181/new/

https://reviews.llvm.org/D154181