[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 29 19:01:55 PDT 2023


ChuanqiXu added a comment.

> Oh, I guess we're somehow adding a semi-resolved form of the base class type of D into the ODR hash, which then includes details of the using-declaration. That seems wrong -- we should either (preferably) be including only the syntactic form of the base specifier (because local syntax is what the ODR covers), or the canonical type (which should be the same for both using-declarations).

Got it. I'll try to fix it. Thanks for the suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153003/new/

https://reviews.llvm.org/D153003



More information about the cfe-commits mailing list