[PATCH] D154145: [HIP] Fix -mllvm option for device lld linker
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 29 14:30:29 PDT 2023
arsenm added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:164
+ StringRef ArgVal = Arg->getValue(1);
+ if (ArgVal.startswith("-mllvm=")) {
+ ArgVal = ArgVal.substr(strlen("-mllvm="));
----------------
StringRef Prefix("-mllvm=") and then use the length instead of strlen
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154145/new/
https://reviews.llvm.org/D154145
More information about the cfe-commits
mailing list