[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 3 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/docs/AMDGPUSupport.rst:33
+   * - ``__AMD__``
+     - Indicates that the code is being compiled for an AMD GPU.
+   * - ``__AMDGPU__``
----------------
jdoerfert wrote:
> FWIW, this arguably confusing use of __AMD__, and duplication of __AMDGPU__, should be deprecated and removed. Or at least not advocated...
will remove from the documentation.


================
Comment at: clang/docs/AMDGPUSupport.rst:54
+     - Defined if FMAF instruction is available (deprecated).
+   * - ``FP_FAST_FMAF``
+     - Defined if fast FMAF instruction is available.
----------------
arsenm wrote:
> The fma macro was actually from the opencl spec but never handled in the correct place
will remove


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154133/new/

https://reviews.llvm.org/D154133