[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a subscriber: aaron.ballman.
MyDeveloperDay added a comment.

@owenpan @HazardyKnusperkeks @rymiel what are your feeling on how we should close old clang-format reviews like this?  (@aaron.ballman any thoughts on how it should be done?)

we end up with lots of reviews that either get metaphorically abandoned, (without actually being abandoned).. should we have some sort of rule, that says reviews left for N months with no activity are automatically abandoned (to do this you have to comindeer the revision, which I don't like doing)

Part of me just wants to consume the unit tests (if they pass).. do you think we should do anything? what about issues we effectively are saying "no to" like D147969 <https://reviews.llvm.org/D147969> but are then not abandoned by the author?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89918/new/

https://reviews.llvm.org/D89918