[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 29 07:59:27 PDT 2023
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM once again with one NIT about the comment line placement.
Thanks!
================
Comment at: clang/lib/Sema/SemaExpr.cpp:18198-18199
+ // - blocks are not allowed inside constant expressions and compiler will
+ // issue an error if they appear there. Hence, in correct code any cleanup
+ // objects created inside current evaluation context must be outside the
+ // immediate invocation.
----------------
NIT: put this on a separate line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153962/new/
https://reviews.llvm.org/D153962
More information about the cfe-commits
mailing list