[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup
Jessica Clarke via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 29 07:45:48 PDT 2023
jrtc27 added inline comments.
================
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:201
-void RISCVIntrinsicManagerImpl::InitIntrinsicList() {
+void RISCVIntrinsicManagerImpl::ConstructRVVIntrinsics(
+ ArrayRef<RVVIntrinsicRecord> Recs, IntrinsicKind K) {
----------------
As far as I can tell this refactoring was entirely gratuitous, and perhaps a regression given the function is only ever used by InitIntrinsicList and thus can be hidden as a lambda?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154050/new/
https://reviews.llvm.org/D154050
More information about the cfe-commits
mailing list