[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 28 12:28:31 PDT 2023


sammccall updated this revision to Diff 535491.
sammccall added a comment.

rebase, primarily on the SAT-inputs-are-ordered change (SetVector etc)

clarify that Formula::print output is supposed to be reliably stable.
This is useful for testing downstream analyses: having a representation of
formulas that can outlive the DataAnalysisContext makes tests more ergonomic.

Change Formula::print back to using a map of atom names instead of a delegate
print function. The extra flexibility is not useful, and it's awkward to use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153366/new/

https://reviews.llvm.org/D153366

Files:
  clang/include/clang/Analysis/FlowSensitive/Arena.h
  clang/include/clang/Analysis/FlowSensitive/DebugSupport.h
  clang/include/clang/Analysis/FlowSensitive/Formula.h
  clang/include/clang/Analysis/FlowSensitive/Solver.h
  clang/include/clang/Analysis/FlowSensitive/WatchedLiteralsSolver.h
  clang/lib/Analysis/FlowSensitive/Arena.cpp
  clang/lib/Analysis/FlowSensitive/CMakeLists.txt
  clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp
  clang/lib/Analysis/FlowSensitive/DebugSupport.cpp
  clang/lib/Analysis/FlowSensitive/Formula.cpp
  clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp
  clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp
  clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp
  clang/unittests/Analysis/FlowSensitive/SolverTest.cpp
  clang/unittests/Analysis/FlowSensitive/TestingSupport.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153366.535491.patch
Type: text/x-patch
Size: 77378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230628/05c36f47/attachment-0001.bin>


More information about the cfe-commits mailing list