[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:78
+        // The value '7' is a hint to this pass to not alter the frm value.
+        if (FRMImm == 7)
+          continue;
----------------
Use `RISCVFPRndMode::DYN`?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:115
+                     // Value to indicate no rounding mode change in
+                     // RISCVInertReadWriteCSR
+                     (XLenVT 7),
----------------
Inert -> Insert


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:116
+                     // RISCVInertReadWriteCSR
+                     (XLenVT 7),
+                     avl, log2sew)>;
----------------
Can we use `FRM_DYN` here? It's defined in RISCVInstrInfoF.td


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:214
+                     // Value to indicate no rounding mode change in
+                     // RISCVInertReadWriteCSR
+                     (XLenVT 7),
----------------
Insert


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:633
+                   // Value to indicate no rounding mode change in
+                   // RISCVInertReadWriteCSR
+                   (XLenVT 7),
----------------
Insert


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:846
+                   // Value to indicate no rounding mode change in
+                   // RISCVInertReadWriteCSR
+                   (XLenVT 7),
----------------
Insert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152996/new/

https://reviews.llvm.org/D152996