[PATCH] D153953: Revert "[AMDGPU] Mark mbcnt as convergent"

Sameer Sahasrabuddhe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 28 06:07:35 PDT 2023


sameerds added a comment.

In D153953#4455794 <https://reviews.llvm.org/D153953#4455794>, @yaxunl wrote:

> Marking mbcnt as convergent, together with https://reviews.llvm.org/D144756 prevent mbcnt to be merged, which fixed the reported issue.
>
> Do you have an alternative fix for the issue?

I completely disagree with this line of thought. The change to mbcnt is fundamentally incorrect and not related to the issue. There is no ground to ask for changes to this revision. Why was the change to mbcnt committed if was not an actual fix for anything?

Also, please note that the issue itself is invalid. I have put a comment in github explaining the same. The original program itself is invalid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153953/new/

https://reviews.llvm.org/D153953



More information about the cfe-commits mailing list