[PATCH] D153882: [clangd] Always allow diagnostics from stale preambles

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:137
     Dict.handle("ClangTidy", [&](Node &N) { parse(F.ClangTidy, N); });
-    Dict.handle("AllowStalePreamble", [&](Node &N) {
-      F.AllowStalePreamble = boolValue(N, "AllowStalePreamble");
----------------
hokein wrote:
> I wonder whether it is worth keeping this flag, but no-op (just emitting an warning message, this flag is no-op).
> 
> Probably not worth, since this flag was introduced recently, and it is not in any release.
that's what happens to unrecognized config keys already. user will get a diag message when parsing their config that says `AllowStalePreamble` is not recognized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153882/new/

https://reviews.llvm.org/D153882