[PATCH] D153860: [clang-tidy] Fix modernize-use-std-print check when return value used

Tue Jun 27 12:57:57 PDT 2023

mikecrowe marked an inline comment as done.
mikecrowe added a comment.

In D153860#4453572 <https://reviews.llvm.org/D153860#4453572>, @dyung wrote:

> @mikecrowe Your change is causing a test failure on the PS4 linux and PS5 Windows build bots. Can you take a look and fix or revert if you need time to investigate?
>
> https://lab.llvm.org/buildbot/#/builders/139/builds/43856
> https://lab.llvm.org/buildbot/#/builders/216/builds/23017

The failure is due to:

  use-std-print.cpp.tmp.cpp:125:3: error: cannot use 'try' with exceptions disabled [clang-diagnostic-error]

I wasn't expecting that!

It looks like I failed to notice that the `bugprone-unused-return-value` check explicitly added `-fexceptions` to the `clang-tidy` command line to avoid this problem. I can add that to hopefully fix the problem, and I had some other changes that I hadn't pushed for review before this landed the first time too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153860/new/

https://reviews.llvm.org/D153860