[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning
Simon Tatham via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 27 08:46:19 PDT 2023
simon_tatham added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:740
-def err_drv_no_matching_multilib : Error<
- "no multilib found matching flags: %0">;
+def warn_drv_no_matching_multilib : Warning<
+ "no multilib found matching flags: %0">,
----------------
Tiny clarity nit: any chance of renaming this identifier to `warn_drv_missing_multilib`, while we're renaming it anyway? Then the command-line option to control the warning matches the identifier inside the code, and makes it easier to guess the spelling of either one if you had the other one already in mind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153885/new/
https://reviews.llvm.org/D153885
More information about the cfe-commits
mailing list