[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:11094
 
+  bool checkLastPrivateForMappedDirectives(ArrayRef<OMPClause *> Clauses);
+  bool mapLoopConstruct(llvm::SmallVector<OMPClause *, 8> *ClausesWithoutBind,
----------------
const member function?
Add a comment


================
Comment at: clang/include/clang/Sema/Sema.h:11095
+  bool checkLastPrivateForMappedDirectives(ArrayRef<OMPClause *> Clauses);
+  bool mapLoopConstruct(llvm::SmallVector<OMPClause *, 8> *ClausesWithoutBind,
+                        ArrayRef<OMPClause *> Clauses,
----------------
Add a comment


================
Comment at: clang/include/clang/Sema/Sema.h:11095
+  bool checkLastPrivateForMappedDirectives(ArrayRef<OMPClause *> Clauses);
+  bool mapLoopConstruct(llvm::SmallVector<OMPClause *, 8> *ClausesWithoutBind,
+                        ArrayRef<OMPClause *> Clauses,
----------------
ABataev wrote:
> Add a comment
`SmallVectorImpl<OMPClause *> &` instead of pointer to fully specified `SmallVector`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144634/new/

https://reviews.llvm.org/D144634