[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

[Jeffrey Byrnes via Phabricator via cfe-commits]

jrbyrnes added a comment.

In D153667#4450517 <https://reviews.llvm.org/D153667#4450517>, @jhuber6 wrote:

> What's the difference here between this and the existing `--hip-link`?

Hi @jhuber6

The commit is poorly named, the main purpose is to introduce `-no-gpu-link-output.`

We want a way to produce relocatable from source. In terms of the Driver, this means building actions and jobs for phases up to `phases::Assemble`. `-no- gpu-link-output` does this by overriding BuildActions to stop after `phases::Assemble` (similar to `-no-gpu-bundle-output`). `-gpu-link-output` is NFCI. COMGR would be the client of this, and it would be up to COMGR to handle linking of the relocatable.

AFAICT, `-hip-link` allows for linking of offload-bundles, so it is conceptually different. We can get (somewhat) close to what we with `-emit-llvm -hip-link`, but that is probably more due to `-emit-llvm`. `-hip-link` by itself produces linker actions / jobs which what we are trying to avoid here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153667/new/

https://reviews.llvm.org/D153667