[PATCH] D153418: Adding iconv support to CharSetConverter class

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

> I think this is reasonable since gcc's fexec-charset option also says the name can be any encoding supported by the iconv library (copy pasted below from https://gcc.gnu.org/onlinedocs/gcc-13.1.0/gcc.pdf) so this would match that behaviour

"gcc did it" doesn't mean the issues raised don't exist; it just means the gcc developers care less about those issues (and they use GNU iconv on Windows, which we can't do).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153418/new/

https://reviews.llvm.org/D153418