[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Thanks for this!  I have no concerns from what I can see, but I see the others are doing a very thorough review, so I'll let them do the approvals.



================
Comment at: clang/include/clang/AST/DeclCXX.h:1911
       setRangeEnd(EndLocation);
-    setIsCopyDeductionCandidate(false);
+    setDeductionCandidateKind(DeductionCandidateKind::Normal);
   }
----------------
ychen wrote:
> cor3ntin wrote:
> > I'm wondering if the constructor should take a `DeductionCandidateKind` defaulted to normal here. All the places where it's set seem to be immediately after construction.
> That's true indeed. The awkward aspect is that the `CXXDeductionGuideDecl::Create` call is far from `setDeductionCandidateKind`; making `CXXDeductionGuideDecl::Create` takes a `DeductionCandidateKind` would several other less related functions takes `DeductionCandidateKind` also.
I'm in favor of having this be a part of CXXDeductionGuideDecl::Create and the ctor as a parameter instead as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139837/new/

https://reviews.llvm.org/D139837