[PATCH] D105759: Implement P2361 Unevaluated string literals

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin marked 2 inline comments as done.
cor3ntin added inline comments.


================
Comment at: clang/lib/AST/Expr.cpp:1140
+  case Unevaluated:
+    return sizeof(char); // Host;
+    break;
----------------
aaron.ballman wrote:
> shafik wrote:
> > Why not grouped w/ `Ordinary` above?
> Specifically because we want the host encoding, not the target encoding.
an unevaluated string is a sequence of 1-byte even on platforms were `sizeof(char)` would be 2 or 4. It's never influenced by the target's properties


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105759/new/

https://reviews.llvm.org/D105759