[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 26 09:06:48 PDT 2023


cor3ntin added inline comments.


================
Comment at: clang/test/Preprocessor/ucn-allowed-chars.c:86
+#define AAA\u0024 // expected-error{{character '$' cannot be specified by a universal character name}} \
+                  // expected-warning{{whitespace}}
+#define AAB\u0040 // expected-error{{character '@' cannot be specified by a universal character name}} \
----------------
aaron.ballman wrote:
> I'd like more context for this diagnostic message because I have no idea what it's trying to warn.
The warning is either
```
whitespace required after macro name 
ISO C99 requires whitespace after the macro name
```
in C++ and C respectively. 

Given it's not salient, I did that. Let me know if you want me to add a different verify tag


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153621/new/

https://reviews.llvm.org/D153621



More information about the cfe-commits mailing list