[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 26 08:36:54 PDT 2023


erichkeane added a comment.

In D153296#4449089 <https://reviews.llvm.org/D153296#4449089>, @yronglin wrote:

> Can we both check `SS->getCond()->containsErrors()` ? Maybe it can avoid bitint's effect. WDYT? @erichkeane @shafik

I'm a TOUCH uncomfortable in that this only fixes the 'current' issue, and is a little fragile perhaps?  The problem we have is that the 'Value' is the incorrect size, which I presume we can get to a couple of ways?  I'd like to make sure we fix as many of those problems as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153296/new/

https://reviews.llvm.org/D153296



More information about the cfe-commits mailing list