[clang] f3ca99a - [clang][OpenMP] Fix unused var warning

David Spickett via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 26 08:21:31 PDT 2023


Author: David Spickett
Date: 2023-06-26T15:20:35Z
New Revision: f3ca99a87c566fb5e910071f4cbb474ddb4e7f37

URL: https://github.com/llvm/llvm-project/commit/f3ca99a87c566fb5e910071f4cbb474ddb4e7f37
DIFF: https://github.com/llvm/llvm-project/commit/f3ca99a87c566fb5e910071f4cbb474ddb4e7f37.diff

LOG: [clang][OpenMP] Fix unused var warning

This was added by 453e02ca0903c9f65529d21c513925ab0fdea1e1.Use
isa instead since we don't use the result.

Fixes:
<..>SemaOpenMP.cpp:23149:13: warning: unused variable ‘TargetVarDecl’ [-Wunused-variable]
23149 |   if (auto *TargetVarDecl = dyn_cast_or_null<VarDecl>(TargetDecl))
      |             ^~~~~~~~~~~~~

Which came up when building with GCC 9.

Added: 
    

Modified: 
    clang/lib/Sema/SemaOpenMP.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp
index 0b6f5be9f0447..e22425b208ccf 100644
--- a/clang/lib/Sema/SemaOpenMP.cpp
+++ b/clang/lib/Sema/SemaOpenMP.cpp
@@ -23146,7 +23146,7 @@ class GlobalDeclRefChecker final
 /// variables with static storage duration in declare target directive.
 void Sema::ActOnOpenMPDeclareTargetInitializer(Decl *TargetDecl) {
   GlobalDeclRefChecker Checker;
-  if (auto *TargetVarDecl = dyn_cast_or_null<VarDecl>(TargetDecl))
+  if (isa<VarDecl>(TargetDecl))
     Checker.declareTargetInitializer(TargetDecl);
 }
 


        


More information about the cfe-commits mailing list