[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!



================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:144
 
+const NamedDecl *pickInterestingTarget(const NamedDecl *D) {
+  // We only support renaming the class name, not the category name. This has
----------------
can you put a function level comment like:
```
Some AST nodes can reference multiple declarations. We try to pick the relevant one to rename here.
```


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1709
+        #include "foo.h"
+        @implementation [[F^oo]]
+        @end
----------------
can you drop the `^` in here. we only iterate over points in the header file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152720/new/

https://reviews.llvm.org/D152720