[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

Mon Jun 26 06:40:17 PDT 2023

cor3ntin added inline comments.

================
Comment at: clang/lib/AST/ExprConstant.cpp:8920
+          if (HasValidResult)
+            CCEDiag(E, diag::note_constexpr_invalid_void_star_cast)
+                << SubExpr->getType() << Info.getLangOpts().CPlusPlus26
----------------
erichkeane wrote:
> Does this diagnostic work?  In the case of the `!C++26`, the arity of the message is different, right?  Do you have a test for this in not c++26 mode that you can post? I Am not sure we do 'fill ins' for discarded 'select' branches.
Yes, we do that in a few places. I added tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153702/new/

https://reviews.llvm.org/D153702