[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 26 06:05:07 PDT 2023
hokein added a comment.
In D153740#4448408 <https://reviews.llvm.org/D153740#4448408>, @avl wrote:
> added @jkorous who originally added llvm::writeFileAtomically.
>
>> Let me know what you think about it -- I considered keeping the llvm::writeFileAtomically and migrating its underlying implementation to llvm::writeToOutput, but it doesn't seem to worth, there are only 4 in-tree usages of this API, I think it is probably better just remove it.
>
> I think it is OK to leave only one API (f.e. llvm::writeToOutput) and remove another. It would probably be better to split this patch to lldb, thinlto, clang and removal parts.
Sounds good. I will split it once https://reviews.llvm.org/D153652 is landed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153740/new/
https://reviews.llvm.org/D153740
More information about the cfe-commits
mailing list