[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name
Chuanqi Xu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 25 19:32:11 PDT 2023
ChuanqiXu added inline comments.
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2043
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isMutable
- Abv->Add(BitCodeAbbrevOp(0)); // StorageKind
+ Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // IsPlaceholder
+ Abv->Add(BitCodeAbbrevOp(0)); // StorageKind
----------------
In case `IsPlaceholder` must be 0 when use the abbreviation for FieldDecl, it is better to use `Abv->Add(BitCodeAbbrevOp(0));` here.
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2077
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isMutable
+ Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // IsPlaceholder
Abv->Add(BitCodeAbbrevOp(0)); // InitStyle
----------------
ditto
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2233
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isARCPseudoStrong
+ Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // IsPlaceholder
Abv->Add(BitCodeAbbrevOp(0)); // Linkage
----------------
ditto
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2311
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isARCPseudoStrong
+ Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // IsPlaceholder
Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // IsThisDeclarationADemotedDefinition
----------------
ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153536/new/
https://reviews.llvm.org/D153536
More information about the cfe-commits
mailing list