[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

Lu Weining via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 25 18:49:49 PDT 2023


SixWeining added inline comments.


================
Comment at: llvm/docs/ReleaseNotes.rst:163
 * The ``lp64s`` ABI is supported now and has been tested on Rust bare-matal target.
+* An target feature ``ual`` is introduced to allow unaligned memory accesses and
+  this feature is enabled by default on generic 64bit processors.
----------------
xen0n wrote:
> nit: "A" (the following sound is not a vowel)
Thanks. I will modify it later.


================
Comment at: llvm/docs/ReleaseNotes.rst:164
+* An target feature ``ual`` is introduced to allow unaligned memory accesses and
+  this feature is enabled by default on generic 64bit processors.
 
----------------
MaskRay wrote:
> xen0n wrote:
> > nit: "for generic 64-bit"
> > 
> > Here "for" (compared to "on") is to signify it's controlled by target instead of host spec.
> Target feature is internal and mentioning it in release notes may be excessive (if we do, there are too many to enumerate ...). I think we can omit mentioning the target feature. Focusing on the behavior about the user-facing `-m[no-]unaligned-access` is more useful.
I think it depends on the different users we are targeting. Command line options like `-m[no-]unaligned-access` are targeting clang users while target features are targeting llvm users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152671/new/

https://reviews.llvm.org/D152671



More information about the cfe-commits mailing list