[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

Sun Jun 25 13:32:18 PDT 2023

mikecrowe added a comment.

In D149280#4447363 <https://reviews.llvm.org/D149280#4447363>, @thakis wrote:

> This breaks tests on windows: http://45.33.8.238/win/80283/step_8.txt
>
> Please take a look and revert for now if it takes a while to fix.

Thanks for letting me know, I thought I could get away with including <inttypes.h> from a test since it is a compiler header rather than a libc header.

I've added a potential fix, but I don't have a Windows machine (or many other targets) to test it on. Is there a way to get this change to run through the buildbots without landing it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149280/new/

https://reviews.llvm.org/D149280