[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

Yueh-Ting (eop) Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 25 08:26:36 PDT 2023


eopXD marked an inline comment as done.
eopXD added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4967
 
+void Sema::checkRVVTypeSupport(QualType Ty, SourceLocation Loc, ValueDecl *D) {
+  const TargetInfo &TI = Context.getTargetInfo();
----------------
craig.topper wrote:
> craig.topper wrote:
> > What about the bool types? Is it sufficient to check Zve32x is enabled after all the other checks? The caller already checked for it being an RVV type so if we are in the function the type is RVV.
> I don't think this comment was addressed
Sorry I misread and only added checks for `vint{8/16/32}*_t`.


Added checks to bool and coverage under `riscv-vector-zve32x-check.c`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153510/new/

https://reviews.llvm.org/D153510



More information about the cfe-commits mailing list