[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 25 08:26:36 PDT 2023
cor3ntin added inline comments.
================
Comment at: clang/lib/Sema/SemaInit.cpp:15
#include "clang/AST/DeclObjC.h"
+#include "clang/AST/Expr.h"
#include "clang/AST/ExprCXX.h"
----------------
ychen wrote:
> shafik wrote:
> > I saw your adding headers. How did you figure out which ones were missing?
> Added headers provide APIs for the new code. I guess many of them are included already indirectly (SmallVector for example). But I thought the best practice is not relying on that, so I added these.
I think it's easier fore reviewers not to add things are are not needed, I would suggest trying to keep the change to the list of includes to the minimum
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139837/new/
https://reviews.llvm.org/D139837
More information about the cfe-commits
mailing list