[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

Mike Crowe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 25 08:26:34 PDT 2023


mikecrowe added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1671
+      notMatches("void x(int, int = 1) { x(0); }",
+                 traverse(TK_IgnoreUnlessSpelledInSource, Call2PlusArgs)));
+  EXPECT_TRUE(
----------------
I'm not sure if this is the best way to trigger testing of the ignoring default argument path in the implementation of `argumentCountAtLeast`, but it does seem to work. I added explicit `TK_AsIs` to the tests above to make it clear that they are not testing that path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153716/new/

https://reviews.llvm.org/D153716



More information about the cfe-commits mailing list