[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

Sat Jun 24 12:50:48 PDT 2023

xbolva00 added a comment.

In D147714#4446780 <https://reviews.llvm.org/D147714#4446780>, @yamt wrote:

>> musttail provide assurances that the tail call can be optimized on all targets.
>
> Such a definition doesn't make much sense because for some targets tail call optimization isn't available at all.
> Eg. Wasm w/o tail call proposal, xtensa windowed abi.
>
> So I'm not sure what's the point of the new attribute. It seems simpler to fix the existing musttail attribute.

I agree, I consider the original design of this feature as a mistake, which made this attribute kinda unreliable and useless.. I dont think people are willing to just change existing impl of musttail attribute...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147714/new/

https://reviews.llvm.org/D147714