[PATCH] D153694: [clang][CodeGen] Remove no-op EmitCastToVoidPtr (NFC)
Youngsuk Kim via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jun 24 08:11:13 PDT 2023
JOE1994 added inline comments.
================
Comment at: clang/lib/CodeGen/CGAtomic.cpp:90
+ StoragePtr = CGF.Builder.CreateAddrSpaceCast(
+ StoragePtr, llvm::PointerType::getUnqual(CGF.getLLVMContext()),
"atomic_bitfield_base");
----------------
barannikov88 wrote:
> I suppose address space shouldn't be dropped here, but this is what the original code does.
>
I agree. I think this can be addressed in a separate revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153694/new/
https://reviews.llvm.org/D153694
More information about the cfe-commits
mailing list