[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jun 24 00:48:47 PDT 2023
tbaeder updated this revision to Diff 534174.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153653/new/
https://reviews.llvm.org/D153653
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/test/AST/Interp/records.cpp
Index: clang/test/AST/Interp/records.cpp
===================================================================
--- clang/test/AST/Interp/records.cpp
+++ clang/test/AST/Interp/records.cpp
@@ -880,3 +880,18 @@
}
}
+namespace TemporaryObjectExpr {
+ struct F {
+ int a;
+ constexpr F() : a(12) {}
+ };
+ constexpr int foo(F f) {
+ return 0;
+ }
+ /// FIXME: This should also work in C++14, but it needs suport for
+ /// CXXConstructExpr. I think.
+#if __cplusplus > 201402L
+ static_assert(foo(F()) == 0, "");
+#endif
+
+}
Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp
===================================================================
--- clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -1011,10 +1011,17 @@
template <class Emitter>
bool ByteCodeExprGen<Emitter>::VisitCXXTemporaryObjectExpr(
const CXXTemporaryObjectExpr *E) {
-
if (std::optional<unsigned> LocalIndex =
allocateLocal(E, /*IsExtended=*/false)) {
- return this->visitLocalInitializer(E, *LocalIndex);
+ if (!this->emitGetPtrLocal(*LocalIndex, E))
+ return false;
+
+ if (!this->visitInitializer(E))
+ return false;
+
+ if (DiscardResult)
+ return this->emitPopPtr(E);
+ return true;
}
return false;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153653.534174.patch
Type: text/x-patch
Size: 1289 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230624/4d5c27dd/attachment.bin>
More information about the cfe-commits
mailing list