[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

Takuya Shimizu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 24 00:26:06 PDT 2023


hazohelet marked an inline comment as done.
hazohelet added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:10821
 
+    // FIXME: No test case for this. Can we remove this block?
     if (FromQs.hasUnaligned() != ToQs.hasUnaligned()) {
----------------
cjdb wrote:
> Please don't commit until this is resolved (either tests added or it's removed).
I opened another diff to remove this block: D153690


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153359/new/

https://reviews.llvm.org/D153359



More information about the cfe-commits mailing list