[PATCH] D117929: [XRay] Add support for RISCV

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 23 20:58:54 PDT 2023


MaskRay added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_trampoline_riscv32.S:16
+	.text
+	.file "xray_trampoline_riscv32.S"
+	.globl __xray_FunctionEntry
----------------
Omit `.file`

Consider using `#include "../sanitizer_common/sanitizer_asm.h"` like aarch64 and x86-64.
This is in case we have RISC-V for other object file formats (say Mach-O) in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117929/new/

https://reviews.llvm.org/D117929



More information about the cfe-commits mailing list