[PATCH] D153670: [clang/HeaderSearch] Make sure `loadSubdirectoryModuleMaps` doesn't cause loading of regular files
Argyrios Kyrtzidis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 23 17:02:02 PDT 2023
akyrtzi marked an inline comment as done.
akyrtzi added inline comments.
================
Comment at: clang/unittests/Tooling/DependencyScannerTest.cpp:274
+ llvm::ErrorOr<std::unique_ptr<llvm::vfs::File>>
+ openFileForRead(const Twine &Path) override {
+ ReadFiles.push_back(Path.str());
----------------
benlangmuir wrote:
> Should we add `status` override as well? I think we don't want to stat it either.
Good idea, see updated patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153670/new/
https://reviews.llvm.org/D153670
More information about the cfe-commits
mailing list