[PATCH] D153476: [dataflow] document & test determinism of formula structure

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp:169
+  auto &BOr = A.makeOr(BY, BX);
+  auto &BEqual = A.makeEquals(BOr, BAnd);
+  EXPECT_EQ(Expected, llvm::to_string(B.getFormula(BEqual)));
----------------
gribozavr2 wrote:
> gribozavr2 wrote:
> > Shouldn't these lines use "A.make...()"?
> Sorry, I meant, shouldn't these lines use "B.make...()"?
oops, good catch!

(this was the test I expected to fail, which convinced me the code being tested was correct. so a bit ironic that the test was wrong and would have passed either way...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153476/new/

https://reviews.llvm.org/D153476