[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 23 12:51:42 PDT 2023
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Seems that the main change is in `llvm/include/llvm/Support/Error.h`. I think there is a small but not negligible chance that this patch may cause a breakage for some build configurations.
I suggest that you land the `#include "llvm/ADT/StringExtras.h"` addition part first, then land a much smaller change that modifes `llvm/include/llvm/Support/Error.h`. So that even if someone detects a failure and decides to revert it, the churn only goes to `llvm/include/llvm/Support/Error.h`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153229/new/
https://reviews.llvm.org/D153229
More information about the cfe-commits
mailing list