[PATCH] D153491: [dataflow] Avoid copying environment

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel added a comment.

In D153491#4443704 <https://reviews.llvm.org/D153491#4443704>, @xazax.hun wrote:

> This sounds extremely error-prone to me. In case copying the analysis state has side effects like this, I would argue we want such operations to be really explicit. What do you think?

Can you expand on this concern? Are you referring to the removal of the unintended copy (ie. this patch), or raising a concern about the how the underlying system handles copies altogether?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153491/new/

https://reviews.llvm.org/D153491