[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp
Sergei Barannikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 23 07:27:57 PDT 2023
barannikov88 added a comment.
In D153229#4444134 <https://reviews.llvm.org/D153229#4444134>, @IncludeGuardian wrote:
> @barannikov88 no it's not. I was going to commit separately to keep the change small, but it turns out that if I move this to the source file there are no additional changes needed. SmallVector.h has now been moved to Error.cpp as well.
I guess it is transitively included from some other header, probably Twine.h.
LGTM with build fixed. I'll leave it for someone else to accept so that it does not disappear from review queue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153229/new/
https://reviews.llvm.org/D153229
More information about the cfe-commits
mailing list